Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@huult how is this looking? |
|
@mountiny I will review this PR today. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-11-16.at.10.36.44.mov |
|
@codex review |
|
@MelvinBot review this |
|
No blocking code findings. Moving parameter enhancement after the storage-readiness barrier correctly avoids capturing the token before hydration (Request.ts:25–30).
|
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@allgandalf I think we should add [No QA] because QA can't test this. |
|
i'd keep QA, they can't hit the bug but they can check SAML sign-in still works and reopening the app keeps you signed in |
|
Updated the Qa steps accordingly |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes a startup session-loading bug to preserve the expected signed-in state, without adding a workflow or making existing article guidance incorrect. |
Explanation of Change
makeXHRadded the session to a request before waiting for the app to load it. On phones, the first request of a launch could go out with no session, get a 407, and send SAML users to their company sign-in page with a good session. The session is now added after the wait.Fixed Issues
$ #106764
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1794471911089309
Tests
[enhanceParameters] Sending request without authTokenline withnotHydratedNew
Request.processWithMiddleware() sends the saved session on a request made as the request code first loadstest added inRequestTest.Offline tests
N/A, this only changes when the session is added to a request.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari